Skip to content

Fix Micrometer no-SLA session metric test#906

Merged
dkropachev merged 1 commit into
fix-prepared-statement-caching-itfrom
fix-micrometer-no-sla-test
May 25, 2026
Merged

Fix Micrometer no-SLA session metric test#906
dkropachev merged 1 commit into
fix-prepared-statement-caching-itfrom
fix-micrometer-no-sla-test

Conversation

@dkropachev
Copy link
Copy Markdown

Summary

  • stub Micrometer histogram lower bound, upper bound, and precision options in the no-SLA session metric test
  • keep the test focused on disabled SLA buckets instead of failing while building distribution configuration

Testing

  • JAVA_HOME=/home/dmitry.kropachev/.sdkman/candidates/java/8.0.452-amzn PATH=/home/dmitry.kropachev/.sdkman/candidates/java/8.0.452-amzn/bin:$PATH mvn -B -ntp -pl metrics/micrometer -Dtest=MicrometerSessionMetricUpdaterTest test

Micrometer requires valid expected histogram bounds even when SLA buckets are disabled. Stub the lowest, highest, and precision options in the no-SLA session metric test so it exercises the intended branch instead of failing while constructing the distribution configuration.
@dkropachev dkropachev requested a review from nikagra May 25, 2026 12:56
@dkropachev dkropachev self-assigned this May 25, 2026
@dkropachev dkropachev merged commit 5e66c61 into fix-prepared-statement-caching-it May 25, 2026
3 checks passed
@dkropachev dkropachev deleted the fix-micrometer-no-sla-test branch May 25, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants