Remove locks for tablets flag on Conn #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
dk/remove-tablet-routing-v1-lock
branch
from
45e3c09 to
6eb181d
Compare
|
@dkropachev can you please add the description also to the commit message? |
Done |
dkropachev
force-pushed
the
dk/remove-tablet-routing-v1-lock
branch
from
6eb181d to
358800f
Compare
policies.go
Outdated
| @@ -651,7 +651,6 @@ func (t *tokenAwareHostPolicy) Pick(qry ExecutableQuery) NextHost { | |||
| var replicas []*HostInfo | |||
|
|
|||
| if qry.GetSession() != nil && qry.GetSession().tabletsRoutingV1 { | |||
| t.tablets.mu.Lock() | |||
There was a problem hiding this comment.
Not sure why this is here, the commit message is about removing Conn.mu locking
There was a problem hiding this comment.
I think it was wierd merge issue, it is gone after rebase
|
pls rebase on master |
dkropachev
force-pushed
the
dk/remove-tablet-routing-v1-lock
branch
from
358800f to
a08be15
Compare
Removes unnecessary `Conn.mu` locking on accessing `tabletsRoutingV1` flag. `Conn.mu` is overused, less it is used less contention is yielded along with more performance.
dkropachev
force-pushed
the
dk/remove-tablet-routing-v1-lock
branch
from
a08be15 to
7dba59c
Compare
done |
sylwiaszunejko
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary
Conn.mulocking on accessingtabletsRoutingV1flag.Conn.muis overused, less it is used less contention is yielded along with more performance.