Fix integer overflow in round-robin load balancing#79
Closed
dkropachev wants to merge 1 commit intomainfrom
Closed
Fix integer overflow in round-robin load balancing#79dkropachev wants to merge 1 commit intomainfrom
dkropachev wants to merge 1 commit intomainfrom
Conversation
Prevent ArrayIndexOutOfBoundsException from AtomicInteger overflow: - Use bitwise AND with Integer.MAX_VALUE to ensure non-negative index - Handle edge case where getAndIncrement() returns Integer.MIN_VALUE - Maintain round-robin distribution while preventing crashes This fixes potential crashes in long-running applications that make billions of requests and experience counter overflow.
f2041e0 to
f441c9c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
(counter & Integer.MAX_VALUE)to ensure non-negative indexTest plan