Fix silent exception swallowing in consumeAndClose#76
Merged
dkropachev merged 1 commit intomainfrom Mar 4, 2026
Merged
Conversation
Replace silent exception swallowing with proper logging: - Log abort failures at WARNING level in consumeAndClose() method - Prevent potential connection pool leaks from undetected abort failures This allows detection and monitoring of stream abort failures that could impact connection pool health.
dkropachev
force-pushed
the
fix/silent-exception-swallowing
branch
from
8edc185 to
0d05b05
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
// ignorecomment with proper WARNING level logging for abort failuresTest plan