Improve connection pool configuration with explicit defaults#74
Merged
dkropachev merged 2 commits intomainfrom Mar 3, 2026
Merged
Improve connection pool configuration with explicit defaults#74dkropachev merged 2 commits intomainfrom
dkropachev merged 2 commits intomainfrom
Conversation
Replace CONNECTION_POOL_DEFAULT sentinel with explicit per-setting defaults in AlternatorConfig. Add info-level logging in CRT factories when zero-value timeouts fall back to SDK defaults. Document asymmetric zero-value semantics across HTTP clients (unlimited for Apache/Netty, unsupported for CRT).
da1b5ff to
6aff809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONNECTION_POOL_DEFAULT = 0("use SDK default") convention with explicit, Alternator-optimized defaults:maxConnections=400,connectionMaxIdleTimeMs=600000(10 min),connectionTimeToLiveMs=0(unlimited),connectionAcquisitionTimeoutMs=10000(10 sec),connectionTimeoutMs=15000(15 sec)connectionAcquisitionTimeoutMs(controls wait time when pool is exhausted) andconnectionTimeoutMs(controls TCP handshake timeout)connectionTimeToLiveMsis setconnectionMaxIdleTimeMs=0connectionMaxIdleTimeMs=0)Breaking changes
CONNECTION_POOL_DEFAULTconstant removed (was0)hasCustomConnectionPoolSettings()method removedmaxConnections=0now throwsIllegalArgumentException(must be positive)Test plan