Skip to content

Conversation

ethanweinberger
Copy link
Contributor

@ethanweinberger ethanweinberger commented Oct 7, 2024

Tutorial accompanies scverse/scvi-tools#2834

Formatting

  • My tutorial has only one top-level (#) header

Reproducibility

  • My tutorial works on Google Colab
  • My tutorial sets scvi.settings.seed = 0 at the beginning of the notebook
  • My tutorial has been run and includes outputs (e.g. plots, tables)

Other

  • Counts and normalized data should co-exist in the datasets, see the API overview for an example
  • For scRNA-seq data, normalization should be counts per median library size and then log1p transformed -- if not, a reason should be given (Note: not applicable to this tutorial as we're not using scRNA-seq)

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@canergen
Copy link
Member

canergen commented Oct 8, 2024

See comments overall looks fine. @ori-kron-wis can you help make the style consistent with other tutorials (I assume removing notebook style commands). These might change rendering on the webpage, which can end up ugly.

@ethanweinberger ethanweinberger force-pushed the methylvi-batch-tutorial branch from 4bb1cbf to fa8837d Compare October 8, 2024 20:38
@ethanweinberger ethanweinberger force-pushed the methylvi-batch-tutorial branch from 4f6af86 to d077c0a Compare October 8, 2024 20:41
@ori-kron-wis
Copy link
Contributor

ori-kron-wis commented Nov 3, 2024

@canergen not so sure what is the problem/difference in style? care to give a few examples?
I could think about adding a save/load model part and also make a new line for each input parameter in a scanpy function (this is to be equivalent to other tutorials)

@ethanweinberger
Copy link
Contributor Author

Hi @canergen. Just wanted to check in to see if you had updates re: my and @ori-kron-wis's previous comments.

Copy link
Member

@canergen canergen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please replace wget with pooch.

@canergen
Copy link
Member

@ori-kron-wis Please merge after adding pooch.

@ori-kron-wis ori-kron-wis merged commit 1cc1b88 into scverse:main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants