Skip to content

Backport PR #3643 on branch 1.11.x ((fix): sc.read with extension does not warn unnecessarily) #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025

Conversation

ilan-gold
Copy link
Contributor

  • (fix): sc.read with extension does not warn unnecessarily

  • (fix): obey return_ext

  • (fix): add extension check internally

  • (chore): relnote

(cherry picked from commit 350c342)

  • Closes #
  • Tests included or not required because:
  • Release notes not necessary because:

* (fix): `sc.read` with extension does not warn unnecessarily

* (fix): obey `return_ext`

* (fix): add extension check internally

* (chore): relnote

(cherry picked from commit 350c342)
@ilan-gold ilan-gold enabled auto-merge (squash) May 28, 2025 12:19
@ilan-gold ilan-gold merged commit 97748a5 into 1.11.x May 28, 2025
9 checks passed
@ilan-gold ilan-gold deleted the auto-backport-of-pr-3643-on-1.11.x branch May 28, 2025 12:29
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.83%. Comparing base (7c27a82) to head (16d9bab).
Report is 2 commits behind head on 1.11.x.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/scanpy/readwrite.py 90.90% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           1.11.x    #3661      +/-   ##
==========================================
+ Coverage   74.82%   74.83%   +0.01%     
==========================================
  Files         115      115              
  Lines       13198    13207       +9     
==========================================
+ Hits         9875     9884       +9     
  Misses       3323     3323              
Files with missing lines Coverage Δ
src/scanpy/readwrite.py 75.51% <90.90%> (+0.51%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant