Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove out of core median #3379

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove out of core median #3379

wants to merge 1 commit into from

Conversation

Intron7
Copy link
Member

@Intron7 Intron7 commented Nov 21, 2024

Computing counts per cell for normalize_total leads to better performance.

@Intron7 Intron7 added this to the 1.11.0 milestone Nov 21, 2024
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.49%. Comparing base (ac19bb3) to head (7d91abc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3379      +/-   ##
==========================================
- Coverage   76.58%   76.49%   -0.09%     
==========================================
  Files         111      111              
  Lines       12862    12865       +3     
==========================================
- Hits         9850     9841       -9     
- Misses       3012     3024      +12     
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_normalization.py 85.36% <100.00%> (-0.35%) ⬇️

... and 8 files with indirect coverage changes

---- 🚨 Try these New Features:

@flying-sheep
Copy link
Member

Fair enough. Can this blow up? I.e. is counts ever big enough that this is a problem?

@flying-sheep flying-sheep modified the milestones: 1.11.0, 1.12.0 Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants