Skip to content

Conversation

@flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Sep 27, 2024

this PR fixes #2744 and

@flying-sheep flying-sheep changed the base branch from pca-dask-sparse to main September 27, 2024 09:33
@flying-sheep flying-sheep changed the title Pca-upstream-sklearn Use upstream sklearn PCA if possible Sep 27, 2024
@codecov
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 95.16129% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.03%. Comparing base (bbcd4b1) to head (7516acc).
Report is 59 commits behind head on main.

Files with missing lines Patch % Lines
src/scanpy/preprocessing/_pca/__init__.py 93.18% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3267      +/-   ##
==========================================
+ Coverage   76.95%   77.03%   +0.08%     
==========================================
  Files         109      110       +1     
  Lines       12465    12492      +27     
==========================================
+ Hits         9592     9623      +31     
+ Misses       2873     2869       -4     
Files with missing lines Coverage Δ
src/scanpy/preprocessing/_pca/_compat.py 100.00% <100.00%> (ø)
src/scanpy/preprocessing/_simple.py 90.64% <ø> (+2.00%) ⬆️
src/scanpy/preprocessing/_pca/__init__.py 91.20% <93.18%> (ø)

@flying-sheep flying-sheep added this to the 1.11.0 milestone Sep 27, 2024
@flying-sheep flying-sheep marked this pull request as ready for review September 27, 2024 11:32
@ilan-gold
Copy link
Contributor

Some comments and questions, some changes needed. Overall, much cleaner :)

@flying-sheep flying-sheep merged commit 3570cd1 into main Oct 18, 2024
@flying-sheep flying-sheep deleted the pca-upstream-sklearn branch October 18, 2024 10:34
@flying-sheep flying-sheep self-assigned this Oct 18, 2024
kaushalprasadhial pushed a commit to sanchit-misra/scanpy that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken test: PCA solver “LOBPCG” can’t handle small test data

3 participants