Skip to content

Change the default number of nearest neighbors search in Ingest #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 18, 2020
Merged

Change the default number of nearest neighbors search in Ingest #1111

merged 3 commits into from
May 18, 2020

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Mar 17, 2020

It was configurable with the default k=10 before, now it uses n_neighbors from sc.tl.neighbors.
As discussed with @falexwolf .

@Koncopd Koncopd requested a review from falexwolf March 17, 2020 10:23
@falexwolf falexwolf mentioned this pull request Mar 17, 2020
Open
15 tasks
@Koncopd
Copy link
Member Author

Koncopd commented May 15, 2020

@falexwolf
Should i merge it?

@ivirshup
Copy link
Member

Could this get a test?

Also, should this be documented somewhere?

@Koncopd Koncopd force-pushed the ingest_defaults branch from 34d23b2 to b43a875 Compare May 17, 2020 12:25
@Koncopd Koncopd force-pushed the ingest_defaults branch from 6ef625e to 354fc87 Compare May 18, 2020 10:51
@falexwolf falexwolf merged commit 82a7da8 into master May 18, 2020
@flying-sheep flying-sheep deleted the ingest_defaults branch August 22, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@falexwolf falexwolf falexwolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Koncopd @ivirshup @falexwolf