-
Notifications
You must be signed in to change notification settings - Fork 0
Add a scipy.sparse numba extension #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CodSpeed Performance ReportMerging #73 will degrade performances by 37.09%Comparing Summary
Benchmarks breakdown
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 98.49% 98.91% +0.42%
==========================================
Files 15 17 +2
Lines 265 370 +105
==========================================
+ Hits 261 366 +105
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -0,0 +1,87 @@ | |||
# SPDX-License-Identifier: MPL-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do wonder if some of these pyi
files could be contributed back to the packages for which they are made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m certainly planning to do that!
Co-authored-by: Ilan Gold <ilanbassgold@gmail.com>
OK, I now made the benchmarks bigger. This way only some
is_constant
tests for sparse matrices are still <1ms (and therefore show up in the regressions). (This is because when reducing along the major axis, many rows/cols without entries can be skipped)