Skip to content

implement and test mean #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 3, 2025
Merged

implement and test mean #44

merged 8 commits into from
Mar 3, 2025

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Mar 3, 2025

Fixes #43

other than the scanpy impl, this uses our sum always to also work on e.g. sparse.

IDK what’s up with these CodSpeed regressions/improvements, these two benchmarks (only) seem to be super flaky

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.05%. Comparing base (bdae03a) to head (47a02ff).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/fast_array_utils/stats/_mean.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   95.32%   95.05%   -0.27%     
==========================================
  Files          11       12       +1     
  Lines         171      182      +11     
==========================================
+ Hits          163      173      +10     
- Misses          8        9       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Mar 3, 2025

CodSpeed Performance Report

Merging #44 will not alter performance

Comparing pa/mean (47a02ff) with main (bdae03a)

Summary

✅ 52 untouched benchmarks
🆕 18 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 test_stats_benchmark[0-numpy.ndarray-float32-mean] N/A 173.8 µs N/A
🆕 test_stats_benchmark[0-numpy.ndarray-float64-mean] N/A 198.7 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csc_array-float32-mean] N/A 362.3 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csc_array-float64-mean] N/A 381.3 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csr_array-float32-mean] N/A 446.4 µs N/A
🆕 test_stats_benchmark[0-scipy.sparse.csr_array-float64-mean] N/A 467 µs N/A
🆕 test_stats_benchmark[1-numpy.ndarray-float32-mean] N/A 177.2 µs N/A
🆕 test_stats_benchmark[1-numpy.ndarray-float64-mean] N/A 195 µs N/A
🆕 test_stats_benchmark[1-scipy.sparse.csc_array-float32-mean] N/A 328.4 µs N/A
🆕 test_stats_benchmark[1-scipy.sparse.csc_array-float64-mean] N/A 353 µs N/A
🆕 test_stats_benchmark[1-scipy.sparse.csr_array-float32-mean] N/A 353.7 µs N/A
🆕 test_stats_benchmark[1-scipy.sparse.csr_array-float64-mean] N/A 386.9 µs N/A
🆕 test_stats_benchmark[None-numpy.ndarray-float32-mean] N/A 196.4 µs N/A
🆕 test_stats_benchmark[None-numpy.ndarray-float64-mean] N/A 202.4 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csc_array-float32-mean] N/A 341.1 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csc_array-float64-mean] N/A 351.9 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csr_array-float32-mean] N/A 327.6 µs N/A
🆕 test_stats_benchmark[None-scipy.sparse.csr_array-float64-mean] N/A 345.6 µs N/A

@flying-sheep flying-sheep requested a review from ilan-gold March 3, 2025 11:25
@flying-sheep flying-sheep merged commit a38413d into main Mar 3, 2025
11 checks passed
@flying-sheep flying-sheep deleted the pa/mean branch March 3, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New function: mean
1 participant