-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix): correct default fill values for dask-sparse #1719
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
- Coverage 86.93% 84.45% -2.49%
==========================================
Files 40 40
Lines 6039 6039
==========================================
- Hits 5250 5100 -150
- Misses 789 939 +150
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn’t look like we use the test “is a sparse matrix/array or a Dask array containing a sparse matrix/array” anywhere else so I’m not suggesting to make this a helper in this PR yet
Dask sparse is only in 0.11 right? I modified the milestones under that assumption. If I’m wrong and you want to backport this, please change it back |
I don't think so, just the API to do i/o is |
OK, needs manual backport then |
read_lazy
for wholeAnnData
lazy-loading +xarray
reading +read_elem_as_dask
->read_elem_lazy
#1247