Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds codeMirrorLoaded that fires after codeMirror set #319

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

sp90
Copy link
Contributor

@sp90 sp90 commented Jan 31, 2023

This solves: #145

@sp90
Copy link
Contributor Author

sp90 commented Jan 31, 2023

Problem with using

  @ViewChild(CodeMirrorComponent) set editor(editor: CodeMirrorComponent) {
    console.log('editor.codeMirror: ', editor.codeMirror);
  }

is that codeMirror is not set here, but only after the codeMirror instance is set which is afterViewInit, so this happens after `viewChild is initiated

And to avoid clunky setTimout code I think it's a quality of life improvement needed to be added

@scttcper
Copy link
Owner

seeing a type error

Error: src/lib/codemirror.component.ts:131:12 - error TS2339: Property 'onLoad' does not exist on type 'CodemirrorComponent'.

@sp90
Copy link
Contributor Author

sp90 commented Jan 31, 2023

@scttcper its been solved

@scttcper scttcper changed the title (feat): adding onload that fires eventemitter after codeMirror instance is set feat: adding onload that fires eventemitter after codeMirror instance is set Jan 31, 2023
@scttcper scttcper changed the title feat: adding onload that fires eventemitter after codeMirror instance is set feat: adds codeMirrorLoaded that fires after codeMirror set Jan 31, 2023
@scttcper scttcper merged commit 1c7d51d into scttcper:master Jan 31, 2023
@scttcper
Copy link
Owner

🎉 This PR is included in version 6.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants