Open
Conversation
…es XML ist noch nicht abgeschlossen-
|
|
Anpassung
Contributor
Author
|
Letzte Anpassung wie besprochen |
jeffreycwitt
requested changes
May 20, 2022
Contributor
jeffreycwitt
left a comment
jeffreycwitt
left a comment
There was a problem hiding this comment.
looks good. Can you just take a look at the couple of comments I made and make sure the XML is valid (check the P tags)
| puto</p> | ||
| <p xml:id="M8ag89-d1e60-d1e277">Per hoc autem instrumentum excusaberis ab omni horologio Nam per ipsum scire poteris | ||
| ascendens in quacumque hora volueris et omnes alias caeli dispositiones quas quaerunt astrologi | ||
| <lb ed="#V"/> |
Contributor
There was a problem hiding this comment.
this line break needs to be deleted
| <lb ed="#O" n="16"/>ntana, et per lo contrario, et parimente come quello di | ||
| <lb ed="#O" n="17"/>ostro il di ostro, et quello di tramontana il di tramontana | ||
| <lb ed="#O" n="18"/>fugge per natura. | ||
|
|
Contributor
There was a problem hiding this comment.
missing close p tag here
| <lb ed="#O" n="21"/>ultima impressione dell'agente, che confonde, et con¬ | ||
| <lb ed="#O" n="22"/>la virtù del primo motore. | ||
| <!--00000014.xml correct position in XML?--> | ||
| <pb ed="#O" n="186-r"/> |
Contributor
There was a problem hiding this comment.
pb should always go in the starting new pargraph rather than at the end of a paragraph
| <!--00000011.xml--> | ||
| <pb ed="#O" n="185-r"/> | ||
| </p> | ||
| <p> |
| <lb ed="#O" n="10"/>tirerebbe più la calamita, che il ferro cosa che è | ||
| <lb ed="#O" n="11"/>falsa come è manifesto per la esperienza; | ||
| <!--00000011.xml--> | ||
| <pb ed="#O" n="185-r"/> |
Contributor
There was a problem hiding this comment.
this should go at the beginning of the next paragraph
|
|
||
| <p xml:id="M8ag89-d1e60-d1e186"> | ||
|
|
||
| <!--did I delete something or is this empty?--> |
Contributor
There was a problem hiding this comment.
leave for now. Jeff can delete later after checking other edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ich habe im Grunde nur den Text per Absatz kopiert. Figuren und anderes XML ist noch nicht abgeschlossen-