Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to text format implemented for Telegram notifications #3150

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mralien
Copy link

@mralien mralien commented Dec 4, 2022

fix #3064, #3100

Description

Added fallback to simple text notification for Telegram channel.
Sometimes sendPhoto API method returns 400 error with "wrong file identifier/HTTP URL specified" description while in reality poster is available, and in result no one receives notifications related to this request.

Example 1 (successful photo notification): The Woman King (2022), tmdb:724495
Example 2 (failed photo notification, falling back to text): Hex (2022), tmdb:988233

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract / nothing related to UI was changed
  • Database migration (if required)

Issues Fixed or Closed

@mralien mralien force-pushed the feat/telegram-noty-fallback-to-text branch 2 times, most recently from 0d0c2e7 to 507b2b4 Compare December 6, 2022 12:53
@mralien
Copy link
Author

mralien commented Dec 6, 2022

For some reason after I built and redeployed my overseerr instance with master + cherry-pick of my commit, even Hex movie start working. But while I was testing everything with plain 1.30.1 it didn't.

@sct
Copy link
Owner

sct commented Dec 31, 2022

For some reason after I built and redeployed my overseerr instance with master + cherry-pick of my commit, even Hex movie start working. But while I was testing everything with plain 1.30.1 it didn't.

To clarify, is this PR still needed? Or is it working as expected?

@mralien
Copy link
Author

mralien commented Jan 2, 2023

I think this PR still needed. Even though Hex (2022, tmdb:988233) works right now with latest official docker image, media without poster at all doesn't produce Telegram notifications - checked on movie (or short movie) HEX (tmdb:593281).

It wouldn't harm either way, because no one can predict when and why poster for any movie/TV show might become unavailable.

update: rebased branch on current develop state

@mralien mralien force-pushed the feat/telegram-noty-fallback-to-text branch 2 times, most recently from 61a399c to 0c1ce24 Compare January 5, 2023 09:27
@mralien mralien force-pushed the feat/telegram-noty-fallback-to-text branch from 0c1ce24 to 0d72040 Compare January 31, 2023 10:21
@DavidJuanes

This comment was marked as spam.

@freakshock88

This comment was marked as spam.

@stale

This comment was marked as resolved.

@stale stale bot added the stale label May 8, 2023
@danshilm danshilm removed the stale label May 9, 2023
@stale

This comment was marked as resolved.

@stale stale bot added the stale label Jul 15, 2023
@danshilm danshilm removed the stale label Jul 16, 2023
@mralien mralien requested a review from OwsleyJr as a code owner September 1, 2023 12:11
@mralien mralien force-pushed the feat/telegram-noty-fallback-to-text branch from 5fdd740 to 59f35af Compare September 1, 2023 12:42
@PCJones
Copy link

PCJones commented Dec 7, 2023

I can confirm this is still needed.

2023-12-07T19:23:19.767Z [error][Notifications]: Error sending Telegram notification {"type":"MEDIA_AUTO_APPROVED","subject":"Willy Wonka & the Chocolate Factory (1971)","errorMessage":"Request failed with status code 400","response":{"ok":false,"error_code":400,"description":"Bad Request: wrong file identifier/HTTP URL specified"}}

This comment was marked as outdated.

@stale stale bot added the stale label Mar 13, 2024
@danshilm danshilm removed the stale label Mar 14, 2024
@mralien mralien force-pushed the feat/telegram-noty-fallback-to-text branch from 59f35af to 119e3a3 Compare July 22, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants