-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fallback to text format implemented for Telegram notifications #3150
base: develop
Are you sure you want to change the base?
Conversation
0d0c2e7
to
507b2b4
Compare
For some reason after I built and redeployed my overseerr instance with master + cherry-pick of my commit, even Hex movie start working. But while I was testing everything with plain 1.30.1 it didn't. |
To clarify, is this PR still needed? Or is it working as expected? |
I think this PR still needed. Even though Hex (2022, tmdb:988233) works right now with latest official docker image, media without poster at all doesn't produce Telegram notifications - checked on movie (or short movie) HEX (tmdb:593281). It wouldn't harm either way, because no one can predict when and why poster for any movie/TV show might become unavailable. update: rebased branch on current develop state |
61a399c
to
0c1ce24
Compare
0c1ce24
to
0d72040
Compare
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
0d72040
to
ba1742c
Compare
ba1742c
to
3e23a53
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
5fdd740
to
59f35af
Compare
I can confirm this is still needed.
|
This comment was marked as outdated.
This comment was marked as outdated.
59f35af
to
119e3a3
Compare
fix #3064, #3100
Description
Added fallback to simple text notification for Telegram channel.
Sometimes sendPhoto API method returns 400 error with "wrong file identifier/HTTP URL specified" description while in reality poster is available, and in result no one receives notifications related to this request.
Example 1 (successful photo notification): The Woman King (2022), tmdb:724495
Example 2 (failed photo notification, falling back to text): Hex (2022), tmdb:988233
To-Dos
yarn build
yarn i18n:extract
/ nothing related to UI was changedIssues Fixed or Closed