Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the phar is not working on HHVM #10

Closed
stof opened this issue May 1, 2014 · 13 comments
Closed

the phar is not working on HHVM #10

stof opened this issue May 1, 2014 · 13 comments

Comments

@stof
Copy link
Contributor

stof commented May 1, 2014

The phar is reported as corrupted in HHVM: https://travis-ci.org/Behat/MinkBrowserKitDriver/jobs/24218053#L122
@AmyStephen
Copy link

I am getting the same error: https://travis-ci.org/Molajo/Molajito/jobs/25213214#L80

@schmittjoh
Copy link
Member

Yeah, this has been reported a couple of times. I'm not sure where exactly there error lies (in PHAR generation or whether it is a bug in HHVM). It should generally be safe to not upload code coverage from the HHVM build though as we just process the upload from the first build right now.

@stof
Copy link
Contributor Author

stof commented May 15, 2014

well, given that PHPUnit 4 supports collecting code coverage from HHVM, why not ?

@AmyStephen
Copy link

@schmittjoh Not sure how I would turn that off. Is there a configuration I can use other than this? I am not certain how to request uploading testing results differently (I believe this came from the Scrutinizer doc.) Thanks! :)

@stof
Copy link
Contributor Author

stof commented May 15, 2014

@AmyStephen if you want to be sure it is not done on HHVM, use the following:

  - sh -c 'if [ "$TRAVIS_PHP_VERSION" != "hhvm" ]; then php ocular.phar code-coverage:upload --format=php-clover coverage.clover; fi;'

@stof
Copy link
Contributor Author

stof commented May 15, 2014

you can skip the download of the phar on HHVM too btw

@AmyStephen
Copy link

Thanks @stof -- that works perfectly for both the phar and the upload. Appreciate the help!

xabbuh added a commit to xabbuh/PandaBundle that referenced this issue Oct 9, 2014
@xabbuh
don't send code coverage reports in HHVM builds
19157d8 
The ocular archive file cannot be executed on HHVM (it's reported to
be corrupted, see scrutinizer-ci/ocular#10 for more information)
@JulienBreux
Copy link

@stof, Thanks a lot!

sebastianbergmann added a commit to sebastianbergmann/money that referenced this issue Nov 27, 2014
@sebastianbergmann
Do not try to send code coverage to ScrutinizerCI for HHVM builds
c62e398 
See scrutinizer-ci/ocular#10 (comment)
@stof
Copy link
Contributor Author

stof commented Dec 2, 2014

@schmittjoh I found facebook/hhvm#4263. It may be related

naxel pushed a commit to naxel/framework that referenced this issue Dec 8, 2014
Not send code coverage to ScrutinizerCI for HHVM builds scrutinizer-c…
acd69d9 
…i/ocular#10
cdaguerre added a commit to cdaguerre/php-trello-api that referenced this issue Dec 15, 2014
@cdaguerre
Disable code coverage from HHVM
981ffd6 
Phar considered corrupt, ref. scrutinizer-ci/ocular#10 and facebook/hhvm#4263
@xabbuh xabbuh mentioned this issue Dec 17, 2014
Merged
@mwjames mwjames mentioned this issue Jan 19, 2015
Closed
@xabbuh
Copy link

xabbuh commented Mar 11, 2015

Can anyone else confirm that this is working (again) with the hhvm and hhvm-nightly builds?

@schmittjoh
Copy link
Member

If not, you can always use the packagist package "scrutinizer/ocular" instead if you would like to send data from an HHVM build.

xabbuh added a commit to xabbuh/panda-client that referenced this issue Mar 11, 2015
@xabbuh
update Travis configuration
6f647c5 
* allow to finish as fast as possible (when either a mandatorybuild
  failed or when only builds allowed to fail have not completed yet)
* run tests with different Symfony versions on PHP 5.6 (was 5.5 before)
* do not run tests with not-maintained Symfony versions
* additionally run tests on PHP 7.0 and HHVM
* send code coverage reports on HHVM too (scrutinizer-ci/ocular#10 does
  not seem to be an issue anymore)
@xabbuh
Copy link

xabbuh commented Mar 11, 2015

Thanks for the hint, @schmittjoh. I don't need it at the moment (I just didn't send the reports in HHVM builds as suggested by @stof in #10 (comment)). Though this might be interesting for others as well.

xabbuh added a commit to xabbuh/PandaBundle that referenced this issue Mar 12, 2015
@xabbuh
update Travis configuration
2d0b365 
send code coverage reports on HHVM too (scrutinizer-ci/ocular#10 does
not seem to be an issue anymore)
xabbuh added a commit to xabbuh/PandaBundle that referenced this issue Apr 13, 2015
@xabbuh
update Travis configuration
7a4cde3 
send code coverage reports on HHVM too (scrutinizer-ci/ocular#10 does
not seem to be an issue anymore)
@williamdes
Copy link

@stof maybe close this issue, HHVM is not something anymore

@stof stof closed this as not planned Won't fix, can't repro, duplicate, stale Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@AmyStephen @schmittjoh @stof @JulienBreux @xabbuh @williamdes