Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented Oct 3, 2023

Description

Reference rust-rfc-workspace-duplicate, workspace-package and workspace-dependecies, add workspace.package and workspace.dependencies to root Cargo.toml:

[workspace.package]
version = "0.1.0"
edition = "2021"
license = "MIT OR Apache-2.0"

[workspace.dependencies]
env_logger = "0.10"
halo2_proofs = { git = "https://github.com/scroll-tech/halo2.git", branch = "develop" }
log = "0.4"
...

So we could update Cargo.toml in sub-projects as:

[package]
name = "zkevm-circuits"
version.workspace = true
edition.workspace = true
license.workspace = true

[dependencies]
halo2_proofs.workspace = true
env_logger.workspace = true
log.workspace = true
...

If it's OK, suppose to move more common dependencies to workspace.dependencies in following PRs.

@lispc lispc merged commit eacc46e into develop Oct 3, 2023
@lispc lispc deleted the normalize-workspace-package-and-dep branch October 3, 2023 14:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants