Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

[feat] testool : more improvements #955

Merged
lispc merged 24 commits into from
Sep 20, 2023
Merged

[feat] testool : more improvements #955

lispc merged 24 commits into from
Sep 20, 2023

Conversation

@lightsing
Copy link
Member

@lightsing lightsing commented Sep 18, 2023 •
edited
Loading

  • 1. exclude-test-ids cli opt
  • 2. for following, skip check_post:
    • hash precompiles
    • ec pairing
    • modexp
    • SELFDESTRUCT
    • DIFFICULTY
    • balance overflow For balance overflow, change balance to 1<<(31*8) - 1. (31 0xff s)
  • 3. for Ignored_SkipTestMaxSteps, still go through bus-mapping processing.
  • 4. inside zkevm-circuits/src/test_util.rs, assert k <= 20
  • 5. control the parallel level of super circuit test

@lispc lispc changed the title [feat] testool exclude-test-ids cli opt [feat] testool : more improvements Sep 19, 2023
@lightsing lightsing marked this pull request as ready for review September 19, 2023 02:12
lispc
lispc reviewed Sep 20, 2023
View reviewed changes
lispc
lispc reviewed Sep 20, 2023
View reviewed changes
lispc
lispc reviewed Sep 20, 2023
View reviewed changes
lispc
lispc reviewed Sep 20, 2023
View reviewed changes
@lispc
Copy link

lispc commented Sep 20, 2023

seems good. i will try to run this branch first.

@lispc lispc merged commit 7fe99fe into develop Sep 20, 2023
@lispc lispc deleted the feat/testool-banlist branch September 20, 2023 17:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lispc lispc lispc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

crate-bus-mapping crate-geth-utils crate-zkevm-circuits

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lightsing @lispc