This repository was archived by the owner on Apr 18, 2025. It is now read-only.
refactor: update the default sign_data #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kunxian-xia can you fix the CI here? |
|
@kunxian-xia what is the status of this pr? |
Author
|
Sorry, I thought this has been merged! I will fix the CI errors asap. |
Author
|
@lispc ready for merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to refactor how the default sign data is created. Previously, the default sign data is generated through
signing the msg(b"1") using 0x01 as the private key and 0x01 as the randomness
k. This is different than the sign data of the padding tx that we use in the tx circuit and pi circuit. Therefore, this sign data is kind of out dated.Type of change
Contents