This repository was archived by the owner on Apr 18, 2025. It is now read-only.
forked from privacy-ethereum/zkevm-circuits
-
Notifications
You must be signed in to change notification settings - Fork 389
Memory opt with word look up #466
Merged
Merged
Changes from all commits
Commits
Show all changes
134 commits
Select commit
Hold shift + click to select a range
484b066
add MemoryWordAddress gadget and todos
DreamWuGit 5a28d4d
update buss mapping MemoryOp with word type value
DreamWuGit d559e4e
update mload/mstore with memory word
DreamWuGit 097b843
fix mload buss mapping test
DreamWuGit 67b0208
add evm circuit with new memory word type and fix mstore circuit test…
DreamWuGit 41b9bf9
fix mload&mstor8 circuit
DreamWuGit ce2e6c9
udpate error invalid creation code circuit
DreamWuGit e022f88
update calldataload buss mapping
DreamWuGit 103ee05
fix calldataload buss map test
DreamWuGit 0e346d9
update calldataload circuit&test pass
DreamWuGit 4fb963e
update log* sha3 calldatacopy buss mapping tests
DreamWuGit 0765b97
add state circuit constraint for memory word tag
DreamWuGit f83a4bf
copy circuit buss mapping add mask field into copy event
DreamWuGit ba676df
copy circuit add value_wrod_rlc
DreamWuGit fe2adfa
add word_index into copy table and align calldata to word
DreamWuGit b8013f0
merging
DreamWuGit e973c0a
fix word_index lt gate issue and move some columns
DreamWuGit 6853367
fix memor word lookup & rw counter
DreamWuGit 2feb995
calldatacopy fix evm circuit root test
DreamWuGit c28f030
fix calldatacopy evm circuit internal test, memory offset overflow fail
DreamWuGit da083e9
fix codecopy bussmapping and copy circuit test pass
DreamWuGit 6a69416
update codecopy evm circuit
DreamWuGit 6a7a745
update exrcodecopy and gen_copy_steps_for_log
DreamWuGit dc3f5c2
try log with byte lookup and refactor
DreamWuGit ea76c6e
update log* with log byte to word and disable rows[0].addr + 1 == row…
DreamWuGit 3146962
update sha3 copy circuit & evm circuit
DreamWuGit f997e5b
Fix test case `test_precompiled_call` in CALL OP. (#485)
silathdiir 2b69717
fix log with non zero start slot and comment multi buss mapping tests
DreamWuGit 7f086bc
add create/return test into copy circuit
DreamWuGit f381072
update return non root non create to generate diff r/w bytes
DreamWuGit b881f21
reading with writing word one by one
DreamWuGit b900b84
[feat] returndatacopy implemented (#506)
lightsing 1bea293
some fix
DreamWuGit ffef4e2
enable and remove state circuit tods
DreamWuGit 2add141
recover test for MemoryWordOp
lightsing 6b8608d
recover test for TxLogOp
lightsing 9118de3
mask is boolean
lightsing e9ada94
word_index [0--32] increase by 1
lightsing 84d2a70
fix copy circuit degree increase issue
DreamWuGit c0ec655
update constraint for read=write vaule for non memory to memory
DreamWuGit ed4d3e4
enable addr change of copy circuit and rename is_word_continue
DreamWuGit 91129f7
Apply suggestions from code review
DreamWuGit 0cff5d2
merging & todo: update callop
DreamWuGit eed0fa7
Merge branch 'memory_opt' of https://github.com/scroll-tech/zkevm-cir…
DreamWuGit 1224c0f
fix not enough row
DreamWuGit dfc787e
memory_opt_opcodes: constraints for MLOAD/MSTORE/MSTORE8/CALLDATALOAD…
naure 8a19276
fix codecopy & log test failures
DreamWuGit 3c6cedb
fix return/create test failures
DreamWuGit c95b4ce
fix returndatacopy& insufficient balance in create
DreamWuGit bf295fb
fix calldatacopy and some clippy
DreamWuGit d8d2380
add constraint for rw counter (#532)
lightsing 92b5a22
restore addr contraint
DreamWuGit 9be2bb2
Fix/callop memory (#555)
lightsing 2045888
fix degree issue
DreamWuGit 399049a
sync & resolve conflict
DreamWuGit 2cc3672
using real length in copy table lookup (#565)
lightsing d815dd0
fix clippy
lightsing 7a7fb5b
replace print to trace
lightsing de4cedc
do not need to suppress theses
lightsing a896165
Merge remote-tracking branch 'origin/develop' into memory_opt
lightsing 33c2b63
fix import
lightsing e55d0b0
fix other crates
lightsing 60fc7b6
fix incomplete comment
lightsing 9ddc105
Merge remote-tracking branch 'scroll/develop' into memory_opt
lispc 85fd6fb
Merge branch 'memory_opt' of github.com:scroll-tech/zkevm-circuits in…
lispc 4a358f2
Add condition for input, output and return bytes for precompile (as b…
silathdiir 5a69b35
Fix to calculate copy length as the minimum value (as bus-mapping). (…
silathdiir 0361459
remove Memory related codes (#574)
lightsing 28d3592
Memory opt update (#541)
naure bcaf2bc
Merge branch 'develop' into memory_opt
DreamWuGit 7340a21
refactor memory_write_word_prev_bytes to memory_write_word
DreamWuGit 2d6b12f
fix clippy
lightsing 1960f12
misc updates
DreamWuGit c021d67
fix constraint
lightsing e9cfffa
Merge remote-tracking branch 'origin/develop' into memory_opt
lightsing 8e9dfb9
fix merge
lightsing 33db3b5
fix fmt & remove unused comment
DreamWuGit 9788372
codecopy buss mapping memory word test
DreamWuGit 7cd0389
update sha3 test and mark get_addr_shift_slot deprecated
lightsing fdd3bb3
better to use usize in addresses
lightsing 9ae1adf
refactor to use Memory::align_range
DreamWuGit 498b473
Merge branch 'memory_opt' of https://github.com/scroll-tech/zkevm-cir…
DreamWuGit 700c757
fix clippy
lightsing b483bce
use Memory::align_range for return_revert
lightsing fc85ecf
remove unnecessary cast
lightsing 0580f74
add a cfg
lightsing 85036c1
rename MemoryWord back to Memory
lispc 5dd5650
rename MemoryWord back to Memory
lispc 78a9716
disable memory tracing by default
lispc 0d24090
fix some typos
lispc 980b747
use &memory_updated
DreamWuGit eff06e3
include copy_rwc_inc in rw_offset
lispc 4e6c292
Merge branch 'memory_opt' of github.com:scroll-tech/zkevm-circuits in…
lispc 93278b9
refactor helper get_copy_bytes
DreamWuGit cc61825
Merge branch 'memory_opt' of https://github.com/scroll-tech/zkevm-cir…
DreamWuGit 8029f28
not a soundness problem anymore
lightsing fb72d3d
apply review
lightsing ba6a42c
refactor write_chunks&write_chunk_for_copy_step
DreamWuGit 33fffd4
Merge branch 'memory_opt' of https://github.com/scroll-tech/zkevm-cir…
DreamWuGit cfc73c8
Merge branch 'develop' into memory_opt
DreamWuGit b6e2f51
Merge branch 'develop' into memory_opt
DreamWuGit 0c246f8
Memory opt refactor (#603)
lightsing c0fb76d
refactor for all copy bytes using rlc_acc equality (#604)
DreamWuGit a38e944
resolve conflicts
DreamWuGit 5ef6c95
fix return_revert
DreamWuGit 5431861
copy_simplify_addr: always increment the address (#609)
naure 702eceb
merge and resolve conflict
DreamWuGit d4aa0ad
Merge branch 'memory_opt' of https://github.com/scroll-tech/zkevm-cir…
DreamWuGit 3b251b2
fix begin_tx copy event
DreamWuGit dff3bf5
fix clippy
DreamWuGit b466fb8
fix scroll feature test failure
DreamWuGit b1fd90c
Copy: fix conditions (#616)
naure 7f0043f
memory_opt_word_end: replace broken LtChip with IsEqualChip (#617)
naure 7d03da0
memory_opt_pad: replace LtChip with a simple column (#620)
naure 108f8b6
memory_opt: Ensure that the word operation completes.
bb00e36
memory_opt_rlc: simplify rlc_acc check (#621)
naure 830312d
word_rlc: introduce value_prev in copy circuit (#626)
naure 8122338
memory_opt_length: constrain length and mask (#628)
naure 212e12d
memory_opt_rwc: fix and simplify RW counter logic (#631)
naure 9e559e5
memory_opt: Prevent an event from spilling into the disabled rows.
7e9ed9a
Delete `memory.clone` in invalid-creation-code error. (#632)
silathdiir 5c5995e
memory_opt: value column is in the first phase
600fda3
Merge branch 'develop' into memory_opt
lispc 61902a0
memory_opt_check_align: require aligned memory addresses in State (#634)
naure 4eecece
Copy: remove LtChip (#635)
naure cfbeb7f
memory_opt_readability: give a name to Rotations (#636)
naure 3963a69
memory_opt: organize variables and comments
72eaa1c
Copy Gadgets (#637)
naure 9474a74
memory_opt: remove unnecessary is_event column
33c0ccb
memory_opt: remove duplicate code in CopyTable::assignments (#638)
naure 1738239
memory_opt: hide details of extend_at_least
ad02341
Avoid whole memory clone when generating copy steps (#629)
silathdiir 9c8470b
Merge branch 'memory_opt' of github.com:scroll-tech/zkevm-circuits in…
958e85b
Fix failed testool cases for memory-copy. (#642)
silathdiir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.