This repository was archived by the owner on Apr 18, 2025. It is now read-only.
[fix] typo in seq exec #1332
Merged
[fix] typo in seq exec #1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lispc
added a commit
that referenced
this pull request
Jul 9, 2024
* add trace jsons to testdata * update mainnet fork height; remove version field in trace * v0.11.2 * fix l1 msg + 1559 * pick some changes from develop * env var SCROLL_MAINNET_CURIE_BLOCK * fix: table kind should not change over the fse code trailing bits * #[serde(default)] for prestate * update mainnet curie block to 7096836 * update l2geth * add vk checking test * add vk checking test * exclude Bernoulli from FixedTable * Revert "add error mcopy test (#1332)" This reverts commit 00cd3e0. * try align with develop * enable vk check * Update test.rs --------- Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed a typo reported by ToB's code review in week 3
I notice that this gate maybe reluctant so it is highly impossible to set up a negative test to achieve a malice attacking (wrong witness but circuit declaimed to be correct). I advice to keep it as a caution and optimize it out later when we have more confidient (that it is reluctant).
CAUTION: It is a BREAKING CHANGE for verifier