This repository was archived by the owner on Apr 18, 2025. It is now read-only.
allow up to 5x compression ratio #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
N_BLOB_BYTEScannot be used inn_rows_data, asn_rows_datais for the "batch" (not for the "blob").We add
N_BATCH_BYTES, which is set to 5x ofN_BLOB_BYTES, which allows up to 5x compression ration from thezstdencoding. We can even set this to 8x, because this is just the upper bound. We have sufficient number of rows to populaten_rows_datasince withk=20we have~ 1 << 20rows.