Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

@DreamWuGit
Copy link

@DreamWuGit DreamWuGit commented Apr 11, 2024

Description

implement mcopy opcode, also need to check if OOG memory copy needs change to support it.

  • Buss mapping

    • add MCopy opcode
    • generate copy steps/event
    • add tests
  • Circuit

    • Mcopy gadget
    • copy circuit change : no need
    • add copy test for mcopy
  • Testing

    • upgrade l1geth to support mcopy opcode
    • testing cases:
      • zero length copy
      • real length copy: one slot + multi slots copy words
      • oog cases for memory copy
      • test tools testing fixed except last one(overlap read/write case), will open another PR for it.

Issue Link

issue #1203

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@DreamWuGit
Copy link
Author

Looking at rw lookup failure in https://circuit-release.s3.us-west-2.amazonaws.com/testool/EIP5656.1714305107.66e981c.html

@DreamWuGit
Copy link
Author

DreamWuGit commented Apr 30, 2024

looking at memory_word_size constraint failure in https://circuit-release.s3.us-west-2.amazonaws.com/testool/EIP5656.1714394392.b8c2c83.html. 4 failures fixed, 12 remains

@lispc
Copy link

lispc commented May 1, 2024

@lispc
Copy link

lispc commented May 1, 2024

@DreamWuGit
Copy link
Author

@DreamWuGit
Copy link
Author

fixed overflow when casting to u64 test tool error, left two now.

@DreamWuGit
Copy link
Author

fixed second panic, remain last one

@lispc
Copy link

lispc commented May 6, 2024

yes https://circuit-release.s3.us-west-2.amazonaws.com/testool/EIP5656.1714972091.dc111f3.html

@lispc lispc merged commit 1cb76ea into develop May 13, 2024
@lispc lispc deleted the feat/mcopy branch May 13, 2024 03:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants