This repository was archived by the owner on Apr 18, 2025. It is now read-only.
Audit Fixes EIP2930/1559 in RLP Circuits #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunxian-xia
approved these changes
Apr 23, 2024
* Remove debug flags * Add decoding table PUSH lookup correspondence * Complete Stack Op Correspondence * fmt * Correct lookup constraint * Remove unused macro * fmt * Correct lookup constraint for pre 2930 txs * fmt * Adjust comments * fmt * Add lookup indicator column for state machine * Add correct condition for stack op lookups * Complete PUSH op lookup * Correct POP op lookup * Correct PUSH lookup * fmt * Add backward compatibility for eip155 and pre155 * Add al_idx to input expression * Add access list idx to PUSH correspondence --------- Co-authored-by: DreamWuGit <wwuwwei@126.com>
* Refactor tx circuit dynamic section after introducing access list * Adjust comments * fmt * Column naming --------- Co-authored-by: DreamWuGit <wwuwwei@126.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
From audit report: https://hackmd.io/umGNoJrZRdmlnzj8lp8xDg#18-Ensure-tx_id-is-the-same-over-access-list-section-in-tx-circuit
Various issues are addressed. Main branch currently contain fixes for issues: 1-11, 15-18, 20, 22, 24
Type of change