This repository was archived by the owner on Apr 18, 2025. It is now read-only.
[Fix]Input parsing for modexp precompile #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mode exp precompile read first 96-bytes of inputs as the expected lengths for the following base, exp and modulus value. In current code, if the input bytes is less than 96, code would wrongly parse the U256 length number with array less than 32 bytes and obtain error value.
For example, if the input has only 1 bytes as '0x01', the code would parse base length as
1
, however, the correct value should be0x01000000000000000000000000000000
(256 bit integer in big-endian).It cause the failure of test case
modexpRandomInput_d1_g0_v0
and has been fixed in this PR.