Skip to content
This repository was archived by the owner on Apr 18, 2025. It is now read-only.

Conversation

@silathdiir
Copy link

Description

Reference security review validated issue-10:

This code:

let is_jumpi = geth_step.op == OpcodeId::JUMPI;
let mut condition: Word = Word::zero();
if is_jumpi {
	condition = geth_step.stack.nth_last(1)?;
}
if is_jumpi {
	state.stack_read(
		&mut exec_step,
		geth_step.stack.nth_last_filled(1),
		condition,
	)?;
}

Could be replace by:

if geth_step.op == OpcodeId::JUMPI {
	state.stack_read(
		&mut exec_step,
		geth_step.stack.nth_last_filled(1),
		geth_step.stack.nth_last(1)?,
	)?;
}

@silathdiir silathdiir requested a review from lispc November 7, 2023 14:01
@lispc lispc merged commit 2470629 into develop Nov 9, 2023
@lispc lispc deleted the security-review-issue-10 branch November 9, 2023 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants