fix(coordinator): set v4.4.56 as minimum prover version #1641
Conversation
WalkthroughThis pull request updates the version tag in Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)level=warning msg="[runner] Can't run linter goanalysis_metalinter: buildir: failed to load package zstd: could not load export data: no export data for "github.com/scroll-tech/da-codec/encoding/zstd"" Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
coordinator/internal/logic/auth/login.go (1)
82-83: Error message inconsistency.The error message references
l.cfg.ProverManager.Verifier.LowVersionCircuit.MinProverVersionbut the actual check uses the hardcoded "v4.4.56". This could be confusing for users who see an error message with a different version than what's actually being enforced.if !version.CheckScrollRepoVersion(login.Message.ProverVersion, "v4.4.56") { - return fmt.Errorf("incompatible prover version. please upgrade your prover, minimum allowed version: %s, actual version: %s", - l.cfg.ProverManager.Verifier.LowVersionCircuit.MinProverVersion, login.Message.ProverVersion) + return fmt.Errorf("incompatible prover version. please upgrade your prover, minimum allowed version: %s, actual version: %s", + "v4.4.56", login.Message.ProverVersion) }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
common/version/version.go(1 hunks)coordinator/internal/logic/auth/login.go(1 hunks)
🔇 Additional comments (3)
common/version/version.go (1)
8-8: Version bump looks appropriate.The version tag has been updated from v4.5.1 to v4.5.2, which aligns with the PR objectives to update deployment tag versioning.
coordinator/internal/logic/auth/login.go (2)
78-81: Temporary fix for backward compatibility looks appropriate.The hardcoded version check is properly documented with a FIXME comment explaining the rationale and future plans. This approach maintains backward compatibility with older prover versions while allowing for the configuration to be used for other checks.
78-81: Don't forget to address the FIXME after Euclid upgrade.The comment indicates this is a temporary solution until after the Euclid upgrade. Consider creating a follow-up task to track this technical debt and ensure it gets addressed at the appropriate time.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
coordinator/internal/logic/provertask/prover_task.go (1)
124-125:❓ Verification inconclusive
Approved: Version check relaxed to include patch versions
The change from exact matching to prefix matching allows prover versions like "v4.4.56-patch1" or "v4.4.56.1" to pass the check, which aligns with the PR objective of setting v4.4.56 as the minimum prover version.
Consider updating the comment on line 124 to explicitly mention that any version starting with "v4.4.56" is now accepted:
- // for backward compatibility, darwin chunk prover can still prove darwinV2 chunk tasks + // for backward compatibility, darwin chunk prover version v4.4.56 or any patched version (starting with v4.4.56) can still prove darwinV2 chunk tasksVerify that the current implementation allows for proper version validation. Consider if you need more robust version comparison:
🏁 Script executed:
#!/bin/bash # Check if there are any other version checks in the codebase that might need similar updates rg -A 2 "ProverVersion\s*(==|!=)" --type goLength of output: 45
Update Required: Comment and Manual Verification Request for Prover Version Check
The update to use a prefix match for prover versions (accepting versions like "v4.4.56-patch1" or "v4.4.56.1") is in line with relaxing the version check. Please update the comment on line 124 as follows:
- // for backward compatibility, darwin chunk prover can still prove darwinV2 chunk tasks + // for backward compatibility, darwin chunk prover version v4.4.56 or any patched version (starting with v4.4.56) can still prove darwinV2 chunk tasksAdditionally, the automated search for other version checks using
==or!=withProverVersionproduced no results. However, please perform a manual verification to ensure that no further parts of the codebase rely on an exact version match and require the same relaxation.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
coordinator/internal/logic/provertask/prover_task.go(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
coordinator/internal/logic/provertask/prover_task.go (2)
common/types/message/message.go (1)
ProofTypeChunk(41-41)coordinator/internal/types/auth.go (1)
ProverVersion(20-20)
⏰ Context from checks skipped due to timeout of 90000ms (10)
- GitHub Check: rollup-db-cli
- GitHub Check: rollup_relayer
- GitHub Check: gas_oracle
- GitHub Check: coordinator-cron
- GitHub Check: bridgehistoryapi-db-cli
- GitHub Check: bridgehistoryapi-fetcher
- GitHub Check: coordinator-api
- GitHub Check: bridgehistoryapi-api
- GitHub Check: tests
- GitHub Check: tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1641 +/- ##
===========================================
+ Coverage 41.35% 41.42% +0.07%
===========================================
Files 222 222
Lines 18319 18319
===========================================
+ Hits 7575 7589 +14
+ Misses 10004 9987 -17
- Partials 740 743 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Purpose or design rationale of this PR
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tagincommon/version.gobeen updated or have you addedbump-versionlabel to this PR?Breaking change label
Does this PR have the
breaking-changelabel?Summary by CodeRabbit