Skip to content

ci: fix TOB-SCREUC-8, do not persist git credentials #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 14, 2025

Conversation

Thegaram
Copy link
Contributor

@Thegaram Thegaram commented Mar 7, 2025

Fix multiple zizmor error like this:

warning[artipacked]: credential persistence through GitHub Actions artifacts
  --> .github/workflows/contracts.yml:30:9
   |
30 |         - name: Checkout sources
   |  _________-
31 | |         uses: actions/checkout@v4
32 | |         with:
33 | |           submodules: recursive
   | |_______________________________- does not set persist-credentials: false
   |
   = note: audit confidence → Low

@Thegaram Thegaram requested review from zimpha and georgehao March 10, 2025 19:50
zimpha
zimpha previously approved these changes Mar 11, 2025
georgehao
georgehao previously approved these changes Mar 14, 2025
Base automatically changed from fix-ga-pin-actions to main March 14, 2025 10:19
@Thegaram Thegaram dismissed stale reviews from georgehao and zimpha March 14, 2025 10:19

The base branch was changed.

@Thegaram Thegaram merged commit d53f065 into main Mar 14, 2025
2 checks passed
@Thegaram Thegaram deleted the fix-ga-do-not-persist-git-credentials branch March 14, 2025 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants