-
Notifications
You must be signed in to change notification settings - Fork 26
feat: euclid phase-2 contract changes #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alejandro Ranchal-Pedrosa <a.ranchalpedrosa@gmail.com>
jonastheis
reviewed
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions:
- maybe I missed it but do we ensure that all messages on
MessageQueueV1
are finalized before we allow finalization ofMessageQueueV2
messages? - for enforced transactions: don't we need to check that all messages on the queue that are older than a certain threshold are included when finalizing? otherwise we don't actually force the sequencer to include them. it could keep censoring forever and permissionless mode would not activate either.
|
Thegaram
reviewed
Feb 17, 2025
Thegaram
reviewed
Feb 18, 2025
Thegaram
reviewed
Feb 18, 2025
Thegaram
reviewed
Feb 18, 2025
Thegaram
reviewed
Feb 20, 2025
jonastheis
reviewed
Feb 20, 2025
Thegaram
approved these changes
Feb 20, 2025
Thegaram
approved these changes
Feb 21, 2025
Thegaram
previously approved these changes
Feb 26, 2025
Thegaram
reviewed
Feb 28, 2025
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Thegaram
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all changes for the planned
EuclidV2
upgrade. Specifically,MessageQueueV2
: instead of iterating through L1 messages and computing the hash at commit time, L1 messages are chained with a rolling hash. so that the last hash represents a commitment to the entire queue.MessageQueueV2
together with the time they have been submitted to L1. If not included/finalized formaxDelayMessageQueue
, the operator can not finalize any more batches until including those messages. If it continues to censor messages permissionless mode will eventually activate.maxDelayEnterEnforcedMode
, batch submission becomes permissionless. Anyone can submit a batch together with a proof.SystemConfig
contract that contains the address of the currently valid signer for L2 blocks. L2 nodes can read and will only accept L2 blocks signed by the given address.