Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync ci #131

Closed
wants to merge 2 commits into from
Closed

fix: sync ci #131

wants to merge 2 commits into from

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Jan 10, 2025

The syncing of the Scroll node was failing due to a gas used mismatch itself stemming from the removal of the code_size on the reth-primitives-traits::Account.

The code_size is used in extcodesize, and removing it from the Account lead to a default value value of 0 to be used for the field when retrieving an account from database and converting it to an revm::primitives::AccountInfo. This further lead to a sync error (gas used mismatach) at block 3404 because an incorrect code size of 0 was used.

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Copy link

codspeed-hq bot commented Jan 10, 2025

CodSpeed Performance Report

Merging #131 will not alter performance

Comparing fix/sync-ci (8b0a1dd) with scroll (88e9188)

Summary

✅ 77 untouched benchmarks

@greged93
Copy link
Collaborator Author

closing in favor of modifying the reth revm scroll branch in order to avoid using code_size field in extcodesize.

@greged93 greged93 closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant