Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove bmpt #125

Merged
merged 6 commits into from
Jan 9, 2025
Merged

feat: remove bmpt #125

merged 6 commits into from
Jan 9, 2025

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Jan 8, 2025

Removes the bmpt implementation of the codebase, only leaving the reth-scroll-trie crate.

Resolves #91

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Copy link

codspeed-hq bot commented Jan 8, 2025

CodSpeed Performance Report

Congrats! CodSpeed is installed 🎉

🆕 77 new benchmarks were detected.

You will start to see performance impacts in the reports once the benchmarks are run from your default branch.

Detected benchmarks

  • recover ECDSA (199.6 µs)
  • validate_blob | num blobs: 1 | ValidateBlob (18.4 µs)
  • validate_blob | num blobs: 2 | ValidateBlob (18.2 µs)
  • validate_blob | num blobs: 3 | ValidateBlob (19.6 µs)
  • validate_blob | num blobs: 4 | ValidateBlob (20.5 µs)
  • validate_blob | num blobs: 5 | ValidateBlob (21.5 µs)
  • validate_blob | num blobs: 6 | ValidateBlob (23.6 µs)
  • prefix set | size: 10 | BTreeSetwithBTreeSet:range lookup (6.3 µs)
  • prefix set | size: 10 | BTreeSetwithIterator:any lookup (5.3 µs)
  • prefix set | size: 10 | Vec with binary search lookup (4.6 µs)
  • prefix set | size: 10 | Vec with custom cursor lookup (4.7 µs)
  • prefix set | size: 100 | BTreeSetwithBTreeSet:range lookup (53.8 µs)
  • prefix set | size: 100 | BTreeSetwithIterator:any lookup (198.2 µs)
  • prefix set | size: 100 | Vec with binary search lookup (28.7 µs)
  • prefix set | size: 100 | Vec with custom cursor lookup (24.4 µs)
  • prefix set | size: 1000 | BTreeSetwithBTreeSet:range lookup (598.2 µs)
  • prefix set | size: 1000 | BTreeSetwithIterator:any lookup (19.8 ms)
  • prefix set | size: 1000 | Vec with binary search lookup (294.9 µs)
  • prefix set | size: 1000 | Vec with custom cursor lookup (209.2 µs)
  • size 100000 | updated 0.1% | depth 0 (4 ms)
  • size 100000 | updated 0.1% | depth 1 (3.9 ms)
  • size 100000 | updated 0.1% | depth 2 (3.8 ms)
  • size 100000 | updated 0.1% | depth 3 (2.7 ms)
  • size 100000 | updated 0.1% | depth 4 (1.6 ms)
  • size 100000 | updated 0.1% | depth 5 (1.3 ms)
  • size 100000 | updated 1% | depth 0 (27.1 ms)
  • size 100000 | updated 1% | depth 1 (27.1 ms)
  • size 100000 | updated 1% | depth 2 (27 ms)
  • size 100000 | updated 1% | depth 3 (24 ms)
  • size 100000 | updated 1% | depth 4 (12.8 ms)
  • size 100000 | updated 1% | depth 5 (9.5 ms)
  • hash builder[1000] (4.5 ms)
  • hash builder[5000] (22.6 ms)
  • sparse trie[1000] (6.3 ms)
  • sparse trie[5000] (31.3 ms)
  • hash builder[init size 1000 | update size 100 | num updates 10] (24.6 ms)
  • hash builder[init size 1000 | update size 100 | num updates 1] (2.4 ms)
  • hash builder[init size 1000 | update size 100 | num updates 3] (7.5 ms)
  • hash builder[init size 1000 | update size 100 | num updates 5] (12.5 ms)
  • hash builder[init size 1000 | update size 1000 | num updates 10] (56.2 ms)
  • hash builder[init size 1000 | update size 1000 | num updates 1] (5.6 ms)
  • hash builder[init size 1000 | update size 1000 | num updates 3] (16.9 ms)
  • hash builder[init size 1000 | update size 1000 | num updates 5] (28.2 ms)
  • hash builder[init size 10000 | update size 100 | num updates 10] (90.6 ms)
  • hash builder[init size 10000 | update size 100 | num updates 1] (9.9 ms)
  • hash builder[init size 10000 | update size 100 | num updates 3] (28.6 ms)
  • hash builder[init size 10000 | update size 100 | num updates 5] (46.7 ms)
  • hash builder[init size 10000 | update size 1000 | num updates 10] (246.4 ms)
  • hash builder[init size 10000 | update size 1000 | num updates 1] (25.5 ms)
  • hash builder[init size 10000 | update size 1000 | num updates 3] (75.5 ms)
  • hash builder[init size 10000 | update size 1000 | num updates 5] (123.4 ms)
  • sparse trie[init size 1000 | update size 100 | num updates 10] (11.8 ms)
  • sparse trie[init size 1000 | update size 100 | num updates 1] (1.3 ms)
  • sparse trie[init size 1000 | update size 100 | num updates 3] (3.6 ms)
  • sparse trie[init size 1000 | update size 100 | num updates 5] (6 ms)
  • sparse trie[init size 1000 | update size 1000 | num updates 10] (53 ms)
  • sparse trie[init size 1000 | update size 1000 | num updates 1] (5.6 ms)
  • sparse trie[init size 1000 | update size 1000 | num updates 3] (16.1 ms)
  • sparse trie[init size 1000 | update size 1000 | num updates 5] (26.7 ms)
  • sparse trie[init size 10000 | update size 100 | num updates 10] (24.6 ms)
  • sparse trie[init size 10000 | update size 100 | num updates 1] (2.6 ms)
  • sparse trie[init size 10000 | update size 100 | num updates 3] (7.5 ms)
  • sparse trie[init size 10000 | update size 100 | num updates 5] (12.4 ms)
  • sparse trie[init size 10000 | update size 1000 | num updates 10] (119.5 ms)
  • sparse trie[init size 10000 | update size 1000 | num updates 1] (12.6 ms)
  • sparse trie[init size 10000 | update size 1000 | num updates 3] (36.5 ms)
  • sparse trie[init size 10000 | update size 1000 | num updates 5] (60.3 ms)
  • parallel hashing[1000] (2.6 s)
  • parallel hashing[100] (258.4 ms)
  • sequence hashing[1000] (2.6 s)
  • sequence hashing[100] (259 ms)
  • receipts root | size: 10 | HashBuilder (110.5 µs)
  • ordered_trie_root (128.1 µs)
  • receipts root | size: 100 | HashBuilder (915 µs)
  • ordered_trie_root (1.2 ms)
  • receipts root | size: 1000 | HashBuilder (9.2 ms)
  • ordered_trie_root (11.9 ms)

Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
@greged93 greged93 requested a review from frisitano January 8, 2025 18:21
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good, LGTM.

@frisitano frisitano merged commit 681264f into scroll Jan 9, 2025
45 checks passed
@frisitano frisitano deleted the chore/clean-bmpt branch January 9, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate support for BMPT
2 participants