Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement and integrate counter-based CCC #982

Merged
merged 31 commits into from
Sep 4, 2024
Merged

feat: implement and integrate counter-based CCC #982

merged 31 commits into from
Sep 4, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Aug 13, 2024 •
edited by Thegaram
Loading

1. Purpose or design rationale of this PR

this PR integrates counter-based CCC and reorging logic that would be triggered on circuit overflows

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop
Copy link
Member

I could just review 74a3430 & c8c79c9?

(Assume #970 & #971 are ready)

@omerfirmak
Copy link
Author

I could just review 74a3430 & c8c79c9?

Yes, exactly

@omerfirmak omerfirmak changed the base branch from develop to feat/lightweight-ccc August 13, 2024 12:33
@omerfirmak omerfirmak force-pushed the omerfirmak/reorging-worker branch 3 times, most recently from 28d23cd to 53a49d0 Compare August 13, 2024 13:35
@omerfirmak omerfirmak force-pushed the omerfirmak/reorging-worker branch 2 times, most recently from 5eaffec to b005c7e Compare August 13, 2024 14:41
@omerfirmak omerfirmak force-pushed the omerfirmak/reorging-worker branch 3 times, most recently from 9b00c11 to b09112c Compare August 15, 2024 10:12
semgrep-app[bot]
semgrep-app bot reviewed Aug 15, 2024
View reviewed changes
internal/debug/flags.go Outdated Show resolved Hide resolved
@omerfirmak omerfirmak force-pushed the omerfirmak/reorging-worker branch 7 times, most recently from a5c3c29 to 7fc6397 Compare August 15, 2024 19:06
Thegaram
Thegaram reviewed Aug 16, 2024
View reviewed changes
miner/scroll_worker.go Show resolved Hide resolved
miner/scroll_worker.go Show resolved Hide resolved
@omerfirmak omerfirmak force-pushed the omerfirmak/reorging-worker branch 5 times, most recently from 3c0874d to d6df38a Compare August 19, 2024 11:31
colinlyguo
colinlyguo previously approved these changes Sep 2, 2024
View reviewed changes
Thegaram
Thegaram previously approved these changes Sep 2, 2024
View reviewed changes
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few questions

eth/tracers/tracers.go Outdated Show resolved Hide resolved
rollup/ccc/logger.go Show resolved Hide resolved
rollup/ccc/logger.go Outdated Show resolved Hide resolved
rollup/ccc/logger.go Show resolved Hide resolved
rollup/ccc/async_checker.go Show resolved Hide resolved
miner/scroll_worker_test.go Show resolved Hide resolved
miner/scroll_worker.go Show resolved Hide resolved
miner/scroll_worker.go Show resolved Hide resolved
@omerfirmak omerfirmak dismissed stale reviews from Thegaram and colinlyguo via 6abc581 September 2, 2024 13:00
colinlyguo
colinlyguo reviewed Sep 2, 2024
View reviewed changes
miner/scroll_worker.go Outdated Show resolved Hide resolved
Thegaram
Thegaram previously approved these changes Sep 3, 2024
View reviewed changes
rollup/ccc/logger.go Show resolved Hide resolved
miner/scroll_worker.go Outdated Show resolved Hide resolved
colinlyguo
colinlyguo previously approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What about adding the bump version tag now? since the pr is almost ready to be merged.

@omerfirmak omerfirmak merged commit e9259b7 into develop Sep 4, 2024
@omerfirmak omerfirmak deleted the omerfirmak/reorging-worker branch September 4, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgehao georgehao georgehao left review comments

@0xmountaintop 0xmountaintop 0xmountaintop left review comments

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@Thegaram Thegaram Thegaram approved these changes

@colinlyguo colinlyguo colinlyguo approved these changes

Assignees
No one assigned
Labels
bump-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@omerfirmak @0xmountaintop @georgehao @Thegaram @colinlyguo @lispc @zimpha