fix(GPO): min suggested tip cap if there's congestion to avoid filtering through DefaultIgnorePrice
#883
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing through `DefaultIgnorePrice`
colinlyguo
reviewed
Jul 5, 2024
jonastheis
force-pushed
the
jt/fix-gpo-min-tip
branch
from
f303d0c to
bdbf820
Compare
colinlyguo
previously approved these changes
Jul 8, 2024
0xmountaintop
previously approved these changes
Jul 8, 2024
jonastheis
dismissed stale reviews from 0xmountaintop and colinlyguo
via
5d187a3
0xmountaintop
approved these changes
Jul 10, 2024
colinlyguo
approved these changes
Jul 10, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Aug 1, 2024
…ing through `DefaultIgnorePrice` (#883)
0xmountaintop
added a commit
that referenced
this pull request
Aug 1, 2024
* feat: congestion-aware gas price oracle (#790) * Implement functionality to reset gas price / suggested tip to minimal value when there's no congestion * Add flags to configure congestion value and initialize gas price oracle accordingly * Fix and add tests to make sure GPO works as expected depending on pre- or post-Curie (EIP 1559) upgrade * Apply review suggestions * chore: auto version bump [bot] --------- Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com> * fix eth/gasprice/gasprice_test.go * minor * fix(GPO): min suggested tip cap if there's congestion to avoid filtering through `DefaultIgnorePrice` (#883) * fix tests * fix tests --------- Co-authored-by: Jonas Theis <4181434+jonastheis@users.noreply.github.com> Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Aug 27, 2024
…ing through `DefaultIgnorePrice` (scroll-tech#883)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
The gas price oracle uses a
oracle.ignorePriceto filter out transactions below a certain price/tip. By default it is set toDefaultIgnorePrice=2 wei.This is problematic as we return a gas price of
1 weiif there's no congestion. This means that other nodes that did not configure with--gpo.ignoreprice=1norgpo.congestionthresholdwill always ignore these low prices and never adjust their price prediction down.By using
2 weias the default price if there's no congestion, other nodes that did not explicitly configure the GPO accordingly will also adjust their prices down without needing to upgrade to this version.Additionally, we set
DefaultIgnorePrice=1 weiso that in the future we can reduce to1 weias the default price with no congestion.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?