feat: turn libscroll_zstd dynamic lib into static #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimpha
previously approved these changes
Jun 4, 2024
0xmountaintop
approved these changes
Jun 4, 2024
georgehao
previously approved these changes
Jun 4, 2024
colinlyguo
changed the title
0xmountaintop
suggested changes
Jun 4, 2024
There was a problem hiding this comment.
this PR depends on scroll-tech/da-codec#8
but IMO scroll-tech/da-codec#8 needs improvement
Or we can add in README to tell devs how to compile the dynamic lib in their local machine. |
colinlyguo
commented
Jun 5, 2024
|
tested in local testnet. |
zimpha
previously approved these changes
Jun 5, 2024
georgehao
previously approved these changes
Jun 5, 2024
zimpha
approved these changes
Jun 5, 2024
0xmountaintop
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Simplify the building workflow.
Support running unit tests and building nccc_geth in darwin arm64.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?