feat: sanity check locally built blocks via local consensus engine #767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
previously approved these changes
May 22, 2024
|
sorry, didn't noticed that some unit tests are failed. they looks meaningful. |
omerfirmak
force-pushed
the
omerfirmak/sanity-check-locally-built-blocks
branch
from
228c860 to
8612810
Compare
and make the entire commit flow synchronous
omerfirmak
force-pushed
the
omerfirmak/sanity-check-locally-built-blocks
branch
from
8612810 to
57dc8d5
Compare
|
simplified the commit flow to be synchronous as well. |
0xmountaintop
previously approved these changes
May 24, 2024
0xmountaintop
approved these changes
May 24, 2024
Thegaram
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if check fails, scratch that and rebuildcontext https://scrollco.slack.com/archives/C05M5U5HST0/p1716395509894609?thread_ts=1716375634.035719&cid=C05M5U5HST0