feat(ccc): reuse a buffer for json encoding #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
reviewed
May 9, 2024
georgehao
reviewed
May 9, 2024
Profiles show that GC churn decreases, but can't really quantify the improvement since there are a lot going on. |
georgehao
previously approved these changes
May 9, 2024
0xmountaintop
previously approved these changes
May 9, 2024
github-actions
bot
dismissed stale reviews from 0xmountaintop and georgehao
via
e43ab4c
colinlyguo
approved these changes
May 9, 2024
georgehao
approved these changes
May 10, 2024
Thegaram
reviewed
May 10, 2024
| } | ||
|
|
||
| tracesByt, err := json.Marshal(traces) | ||
| ccc.jsonBuffer.Reset() |
There was a problem hiding this comment.
What if we encounter an exceptionally large trace, would we just keep the allocated buffer, even though we almost never fully utilize it?
There was a problem hiding this comment.
Yeah, that is the trade-off here. Such peaks of memory usage become sticky.
There was a problem hiding this comment.
After disabling stack, I think we won't have such large traces as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
...
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?