Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ethapi): add state override to estimateGas #575

Closed
wants to merge 5 commits into from
Closed

feat(ethapi): add state override to estimateGas #575

wants to merge 5 commits into from

Conversation

GDdark
Copy link

@GDdark GDdark commented Nov 21, 2023

1. Purpose or design rationale of this PR

This PR is a code synchronization from Ethereum, the changes are as follows

  1. ethapi: add state override to estimateGas
  2. add api tests for eth_call and eth_estimateGas

Related issue: ethereum#27845

For me personally
this feature is very helpful for ERC-4337 to estimate gasUsed of the userOp in some cases

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram
Copy link

Hi @GDdark, please run this command:

goimports -local github.com/scroll-tech/go-ethereum/ -w .

@GDdark
Copy link
Author

GDdark commented Nov 25, 2023

@Thegaram Done

@GDdark GDdark closed this by deleting the head repository Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants