Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api/rawdb): allow storing traces for skipped txs #500

Merged
merged 13 commits into from
Sep 5, 2023

Conversation

0xmountaintop
Copy link
Member

@0xmountaintop 0xmountaintop commented Sep 4, 2023

1. Purpose or design rationale of this PR

Currently it's hard to debug a skipped tx if it's rejected by ccc, because its traces is never store. This PR adds a flag and store the skipped txs' traces when the flag is enabled.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the title Store/skipped traces feat(api/rawdb): allow store traces for skipped txs Sep 4, 2023
@0xmountaintop 0xmountaintop marked this pull request as ready for review September 4, 2023 09:39
internal/ethapi/api.go Outdated Show resolved Hide resolved
internal/ethapi/api.go Outdated Show resolved Hide resolved
core/rawdb/accessors_skipped_txs.go Show resolved Hide resolved
@0xmountaintop 0xmountaintop changed the title feat(api/rawdb): allow store traces for skipped txs feat(api/rawdb): allow storing traces for skipped txs Sep 4, 2023
Thegaram
Thegaram previously approved these changes Sep 4, 2023
georgehao
georgehao previously approved these changes Sep 5, 2023
@scroll-dev scroll-dev merged commit 0b6c3be into develop Sep 5, 2023
5 checks passed
@scroll-dev scroll-dev deleted the store/skipped_traces branch September 5, 2023 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants