forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api/rawdb): allow storing traces for skipped txs #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 4, 2023 08:33
c11f0ac
to
3cbb619
Compare
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 4, 2023 08:56
0eacabd
to
2f643ef
Compare
0xmountaintop
changed the title
Store/skipped traces
feat(api/rawdb): allow store traces for skipped txs
Sep 4, 2023
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 4, 2023 10:03
cbf5561
to
d463e3c
Compare
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 4, 2023 10:34
528da52
to
7d908e6
Compare
13 tasks
Thegaram
reviewed
Sep 4, 2023
0xmountaintop
changed the title
feat(api/rawdb): allow store traces for skipped txs
feat(api/rawdb): allow storing traces for skipped txs
Sep 4, 2023
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 4, 2023 13:30
39d42a9
to
82483e5
Compare
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 4, 2023 13:41
82483e5
to
86e2fb3
Compare
Thegaram
previously approved these changes
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
reviewed
Sep 4, 2023
georgehao
previously approved these changes
Sep 5, 2023
0xmountaintop
force-pushed
the
store/skipped_traces
branch
from
September 5, 2023 02:57
9888d49
to
1034738
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Currently it's hard to debug a skipped tx if it's rejected by ccc, because its traces is never store. This PR adds a flag and store the skipped txs' traces when the flag is enabled.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?