fix: exclude L1 message from block payload size validation #476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
0xmountaintop
previously approved these changes
Aug 23, 2023
* fix bug when calculate l2 tx count * Update version
Thegaram
added a commit
that referenced
this pull request
Aug 25, 2023
* fix: exclude L1 message from block payload size validation * fix the bug when calculating l2TxCount. (#479) * fix bug when calculate l2 tx count * Update version * bump version --------- Co-authored-by: maskpp <maskpp266@gmail.com>
Thegaram
added a commit
that referenced
this pull request
Aug 25, 2023
* feat: store skipped txs in local db * bump version * bump version * fix test * include L2 txs in skipped index * goimports * rename more * bump version * fix missed renames * fix the bug when calculating l2TxCount. (#479) * fix bug when calculate l2 tx count * Update version * fix: exclude L1 message from block payload size validation (#476) * fix: exclude L1 message from block payload size validation * fix the bug when calculating l2TxCount. (#479) * fix bug when calculate l2 tx count * Update version * bump version --------- Co-authored-by: maskpp <maskpp266@gmail.com> * fix: update row estimation with scroll-prover `v0.7.2` (#475) * Fix row estimation. * Update libzkp. * more * prepare * finish * upgrade * bump version * fix tests * Update to scroll-prover `v0.7.2`. * fix tests * Update miner/worker.go Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * Update miner/worker.go Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * Reset ccc when skips first tx. * do not unnecessarily skip L1 message * fix ccc reset and improve code readability * seal block on circuitcapacitychecker.ErrUnknown --------- Co-authored-by: HAOYUatHZ <haoyu@protonmail.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * refactor: simplify ccc revert to snapshot (#480) * simplify ccc revert to snapshot * Update version.go --------- Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> * feat: use --gcmode=archive and --cache.noprefetch=true by default (#482) * feat: use --gcmode=archive and --cache.noprefetch=true by default * refuse to start with invalid config * lint * lint * feat(sdk): support compressed response (#469) * enable use compression algorithm * fix ci * Just enable decode compressed content at ethclient * fix comments --------- Co-authored-by: Haichen Shen <shenhaichen@gmail.com> * fix: disable pruning and prefetch if not flags are provided (#483) Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com> * fix: update libzkp to use scroll-prover `v0.7.5` (#484) * Update libzkp to use scroll-prover `v0.7.5`. * Update version. * address comments * bump version * nit --------- Co-authored-by: maskpp <maskpp266@gmail.com> Co-authored-by: Steven <asongala@163.com> Co-authored-by: HAOYUatHZ <haoyu@protonmail.com> Co-authored-by: iczc <iczcalan@gmail.com> Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Co-authored-by: Haichen Shen <shenhaichen@gmail.com> Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Currently, both
workerandblock_validatorconsider L1 messages when enforcing the block payload size limit. This is wrong (an unnecessary over-estimation), since L1 messages are not part of the batch payload.It is risky to merge this fix in this form. It has the risk that we produce a block that's valid according to the updated size limit, but is still rejected by old-version nodes. This risk is limited by the fact that we currently only allow 10 L1 messages per block. An alternative, safer roll-out is:
block_validatorpart.workerpart.2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?