Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm: implement EIP-3860: Limit and meter initcode (#23847) #318

Merged
merged 7 commits into from
May 18, 2023
Merged

core/vm: implement EIP-3860: Limit and meter initcode (#23847) #318

merged 7 commits into from
May 18, 2023

Conversation

NazariiDenha
Copy link

@NazariiDenha NazariiDenha commented May 9, 2023 •
edited
Loading

Implementation of https://eips.ethereum.org/EIPS/eip-3860, limit and meter initcode.

@gumb0 @lightclient
@holiman @MariusVanDerWijden @NazariiDenha
core/vm: implement EIP-3860: Limit and meter initcode (ethereum#23847)
30b2a0b 
Implementation of https://eips.ethereum.org/EIPS/eip-3860, limit and meter initcode. This PR enables EIP-3860 as part of the Shanghai fork.

Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
Co-authored-by: Martin Holst Swende <martin@swende.se>
Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de>
@NazariiDenha NazariiDenha marked this pull request as draft May 9, 2023 14:59
Thegaram
Thegaram reviewed May 10, 2023
View reviewed changes
core/state_processor_test.go Outdated Show resolved Hide resolved
core/vm/gas_table.go Show resolved Hide resolved
@NazariiDenha NazariiDenha marked this pull request as ready for review May 10, 2023 16:39
@Thegaram Thegaram mentioned this pull request May 12, 2023
Merged
Thegaram
Thegaram reviewed May 12, 2023
View reviewed changes
light/txpool.go Outdated Show resolved Hide resolved
params/protocol_params.go Outdated Show resolved Hide resolved
@Thegaram Thegaram requested a review from maxwolff May 15, 2023 07:15
@rrzhang139 rrzhang139 self-requested a review May 16, 2023 16:33
rrzhang139
rrzhang139 reviewed May 16, 2023
View reviewed changes
Copy link

@rrzhang139 rrzhang139 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has IntrinsicGas been updated on this file as well?

maxwolff
maxwolff reviewed May 17, 2023
View reviewed changes
params/protocol_params.go Outdated Show resolved Hide resolved
colinlyguo
colinlyguo approved these changes May 18, 2023
View reviewed changes
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@NazariiDenha NazariiDenha merged commit c5da652 into develop May 18, 2023
@NazariiDenha NazariiDenha deleted the implement-eip-3860 branch May 18, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rrzhang139 rrzhang139 rrzhang139 left review comments

@Thegaram Thegaram Thegaram approved these changes

@colinlyguo colinlyguo colinlyguo approved these changes

@maxwolff maxwolff maxwolff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NazariiDenha @Thegaram @maxwolff @rrzhang139 @colinlyguo @gumb0