Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core, trie, eth, cmd: rework preimage store #205

Merged
merged 8 commits into from
Feb 10, 2023

Conversation

0xmountaintop
Copy link

@0xmountaintop 0xmountaintop commented Jan 29, 2023

cherry pick ethereum@9d76a9b

This PR is to fix preimages field's concurrent map operation panic, and it;s fixed in ethereum/go-ethereum(PR ethereum#25287). The key point is to add RW lock in preimage.

mask-pp
mask-pp previously approved these changes Jan 30, 2023
noel2004
noel2004 previously approved these changes Feb 1, 2023
Copy link
Member

@noel2004 noel2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and we can test to decide there is no racing condition on preimage updating anymore.

trie/zk_trie_database.go Show resolved Hide resolved
@0xmountaintop 0xmountaintop dismissed stale reviews from noel2004 and mask-pp via d649356 February 1, 2023 12:28
@0xmountaintop 0xmountaintop merged commit 0854d4b into staging Feb 10, 2023
@0xmountaintop 0xmountaintop deleted the fix/preimages-data-race_3 branch February 10, 2023 07:26
@OrestTa
Copy link

OrestTa commented Feb 10, 2023

@HAOYUatHZ @Thegaram when (if already) was this deployed and to which ENV?

@Thegaram
Copy link

@HAOYUatHZ @Thegaram when (if already) was this deployed and to which ENV?

Not deployed. This branch contains breaking changes so we cannot easily deploy on prealpha-main.

chokobole added a commit to kroma-network/go-ethereum that referenced this pull request Mar 10, 2023
chokobole added a commit to kroma-network/go-ethereum that referenced this pull request Mar 10, 2023
chokobole added a commit to kroma-network/go-ethereum that referenced this pull request Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zktrie may lead to a race condition and crash geth when preimage is enabled
6 participants