feat(feynman): compute compression ratio on tx data

[Thegaram]

1. Purpose or design rationale of this PR

Update rollup fee formula:

rollup_fee(tx) = penalty(tx) * size(encode_eip2718(tx)) * (
	exec_scalar * l1_base_fee + 
	blob_scalar * l1_blob_base_fee
)

penalty(tx) = compression_ratio(tx) < penalty_threshold ? penalty_value : 1

compression_ratio(tx) = size(tx.data) > 0 ? max(size(tx.data) / size(zstd(tx.data)), 1) : U256MAX   // !!

Note:

1. Rollup fee is still multiplied by the full encoded transaction (EIP-2718, or RLP for legacy txs).
2. The compression ratio is computed on tx.data (payload) only, ignoring other tx fields (signature, etc.)
3. Transactions with no payload (i.e. simple ETH transfers) will not be penalized.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

• This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
• Yes

4. Breaking change label

Does this PR have the breaking-change label?

• This PR is not a breaking change
• Yes

Summary by CodeRabbit

• Bug Fixes

  • Improved handling of empty transaction data when estimating compression ratio, now returning a maximum value instead of an error.
  • Refined logic for calculating compression ratios, addressing edge cases for more accurate results.

• New Features

  • Added a new test case for compression ratio estimation.

• Tests

  • Updated and expanded test coverage for compression ratio estimation, including revised test inputs and expected outcomes.

• Chores

  • Incremented the patch version number.

[coderabbitai]

Walkthrough

This change increases the patch version constant, refines the logic for estimating transaction compression ratios, adjusts the fee calculation to use transaction data payloads, and updates related tests with new input data, expected values, and improved error handling. A new test case is also added.

Changes

File(s)	Change Summary
params/version.go	Incremented VersionPatch constant from 62 to 63.
rollup/fees/rollup_fee.go	Added U256MAX variable, refined estimateTxCompressionRatio logic to handle empty data, reordered checks, changed fee calculation to use tx.Data(), updated comments.
rollup/fees/rollup_fee_test.go	Refactored tests to use a helper function, changed test inputs and expected compression ratios, improved error handling for empty data, added a new test case.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant FeeCalculator as CalculateL1DataFee
    participant Compression as estimateTxCompressionRatio

    User->>FeeCalculator: Provide Transaction (tx)
    FeeCalculator->>Compression: Pass tx.Data() and config
    Compression-->>FeeCalculator: Return compression ratio (U256MAX if empty)
    FeeCalculator-->>User: Return calculated L1 data fee

Loading

Possibly related PRs

• scroll-tech/go-ethereum#1216: Adds new test cases for compression ratio, modifying the same test function but with a different scope.
• scroll-tech/go-ethereum#1196: Originally introduced the compression-aware fee formula and related functions, which are refined in this PR.

Suggested labels

bump-version

Suggested reviewers

• colinlyguo
• georgehao

Poem

The patch hops up, a number anew,
Compression logic gets a clearer view.
Payloads are shorter, the tests now align,
Ratios update, results look fine.
With every commit, we leap ahead—
A rabbit’s delight in green and red! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3128c52 and ae02dfb.

📒 Files selected for processing (1)

• rollup/fees/rollup_fee_test.go (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• rollup/fees/rollup_fee_test.go

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: test
• GitHub Check: check
• GitHub Check: Analyze (go)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.