Skip to content

feat: add metrics finalized block #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: add metrics finalized block #1172

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ec71458
feat: add metrics chain/head/finalized
yiweichi Apr 23, 2025
0732859
bump version
yiweichi Apr 23, 2025
49b2e3f
fix: lint
yiweichi Apr 23, 2025
f7d4ea4
Merge branch 'develop' into feat-add-metrics-finalized-block
yiweichi Apr 28, 2025
052f3b6
Merge branch 'develop' into feat-add-metrics-finalized-block
yiweichi Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion rollup/rollup_sync_service/rollup_sync_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import (
"github.com/scroll-tech/go-ethereum/core/rawdb"
"github.com/scroll-tech/go-ethereum/ethdb"
"github.com/scroll-tech/go-ethereum/log"
"github.com/scroll-tech/go-ethereum/metrics"
"github.com/scroll-tech/go-ethereum/node"
"github.com/scroll-tech/go-ethereum/params"
"github.com/scroll-tech/go-ethereum/rollup/da_syncer"
Expand All @@ -43,7 +44,10 @@ const (
defaultLogInterval = 5 * time.Minute
)

var ErrShouldResetSyncHeight = errors.New("ErrShouldResetSyncHeight")
var (
finalizedBlockGauge = metrics.NewRegisteredGauge("chain/head/finalized", nil)
ErrShouldResetSyncHeight = errors.New("ErrShouldResetSyncHeight")
)

// RollupSyncService collects ScrollChain batch commit/revert/finalize events and stores metadata into db.
type RollupSyncService struct {
Expand Down Expand Up @@ -135,6 +139,11 @@ func (s *RollupSyncService) Start() {

log.Info("Starting rollup event sync background service", "latest processed block", s.callDataBlobSource.L1Height())

finalizedBlockHeightPtr := rawdb.ReadFinalizedL2BlockNumber(s.db)
if finalizedBlockHeightPtr != nil {
finalizedBlockGauge.Update(int64(*finalizedBlockHeightPtr))
}

go func() {
syncTicker := time.NewTicker(defaultSyncInterval)
defer syncTicker.Stop()
Expand Down Expand Up @@ -321,6 +330,7 @@ func (s *RollupSyncService) updateRollupEvents(daEntries da.Entries) error {
return fmt.Errorf("failed to batch write finalized batch meta to database: %w", err)
}
rawdb.WriteFinalizedL2BlockNumber(s.db, highestFinalizedBlockNumber)
finalizedBlockGauge.Update(int64(highestFinalizedBlockNumber))
rawdb.WriteLastFinalizedBatchIndex(s.db, batchIndex)
log.Debug("write finalized l2 block number", "batch index", batchIndex, "finalized l2 block height", highestFinalizedBlockNumber)

Expand Down
Loading