-
Notifications
You must be signed in to change notification settings - Fork 282
feat(tx-pool): fast reject transactions that cannot fit into a block #1042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think also need to catch |
if |
if you don't deal with the error, the exist error tx will stay in the txpool forever |
A reboot will get rid of those txns, it is fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be nice to add a test to avoid a regression in the future
0ee3c12
added in 9cc2719. |
makes sense. I also believe reboot and repropagation (then rejection by tx pool) can resolve this. |
b543388
…croll-tech#1042) * feat(tx pool): fast reject transactions that cannot fit into a block * add a TestValidateTxBlockSize unit test * chore: auto version bump [bot] --------- Co-authored-by: colinlyguo <colinlyguo@users.noreply.github.com>
1. Purpose or design rationale of this PR
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?