Skip to content

feat(rpc): add getTxByTxTrace api, used for ccc testing & debugging #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 6, 2024

Conversation

lispc
Copy link

@lispc lispc commented Sep 6, 2024

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@lispc
Copy link
Author

lispc commented Sep 6, 2024

this pr does not change any imports..? why 'goimports -local github.com/scroll-tech/go-ethereum/ -w .' is not ok...

@colinlyguo
Copy link
Member

this pr does not change any imports..? why 'goimports -local github.com/scroll-tech/go-ethereum/ -w .' is not ok...

might be the golang version of CI (encountered the same issue before). btw, what is the original motivation to increase version 1.21?

@lispc lispc merged commit 665f6c3 into develop Sep 6, 2024
8 checks passed
@lispc lispc deleted the omerfirmak/tx-by-tx-tracer branch September 6, 2024 15:22
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Dec 16, 2024
…croll-tech#1026)

* ++

* upgrade go lint version

* lint

* remove a useless "`"

* Update l2geth_ci.yml

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants