(depreciated) Improvment for the first phase of zktrie #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Let blockResult limit settable * fix bug * Update cmd/geth/usage.go Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com> Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
|
I suggest you open another PR (squash all commits into 1) against zkrollup branch. And prefix "depreciated" to title of this one. Dont close this one. So we can have a look at diff for both base branches |
|
Ok, one moment
|
mask-pp
reviewed
May 18, 2022
core/blockchain.go
Outdated
| @@ -1188,8 +1188,15 @@ func (bc *BlockChain) writeKnownBlock(block *types.Block) error { | |||
| return nil | |||
| } | |||
|
|
|||
| // EvmTxTraces groups trace data from each executation of tx and left | |||
| // some field to be finished from blockResult | |||
| type EvmTxTraces struct { | |||
There was a problem hiding this comment.
Moving EvmTxTraces to core/types/l2trace.go might be more concentrated.
There was a problem hiding this comment.
get it, may us just move to #101 for more reviewing?
noel2004
changed the title
noel2004
changed the title
* Upgrade trace code to decrease GC pressure. * Fix golangci bug * Add goproxy * update docker file * trigger ci * trigger ci * Upgrade code * Upgrade code * trigger ci Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
pdrobnjak
pushed a commit
to Tenderly/net-scroll-geth
that referenced
this pull request
Apr 30, 2025
* refactor miner * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work has finished the first part of a better PR for zktrie: inducing zktrie as an alternative storage layer and providing a more effective, unitify logging scheme for the L2 trace.
There is some breaking change for the trace output comparing to current zktrie work branch:
I think these changes has no affection on the trace handling of roller because no module would refer the proof part except for the mpt-circuit