Remove user parameter from getGate method #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
robertvansteen
approved these changes
Feb 28, 2019
Codecov Report
@@ Coverage Diff @@
## 2.1 #99 +/- ##
=========================================
Coverage 84.64% 84.64%
+ Complexity 651 650 -1
=========================================
Files 76 76
Lines 1902 1902
=========================================
Hits 1610 1610
Misses 292 292
Continue to review full report at Codecov.
|
erikgaal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in a new feature in Laravel 5.8, policies aren't loaded when using the policy name guesser and
Gate::forUserlaravel/framework#27708.Since this call isn't really required, as the authenticated user is the same as the passed one here, we can remove the call to simply fix this issue right now.