Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make order of tables during schema creation irrelevant #96

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

arybczak
Copy link
Collaborator

Creation of primary key was unnecessarily omitted until second stage and created along with foreign keys, but a primary key includes a unique index, so it might have happened that a foreign key couldn't be created, because the primary key related index it needed wasn't created yet and order of tables on the list had to be adjusted.

Creation of primary key was unnecessarily omitted until second stage and created
along with foreign keys, but a primary key includes a unique index, so it might
have happened that a foreign key couldn't be created, because the primary key
related index it needed wasn't created yet and order of tables on the list had
to be adjusted.
@arybczak arybczak requested a review from jsynacek May 21, 2023 23:17
Copy link
Contributor

@jsynacek jsynacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@arybczak arybczak merged commit 5ce432c into master May 22, 2023
@arybczak arybczak deleted the fix-order branch May 22, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants