Fix the logic that checks indices on foreign keys #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arybczak
approved these changes
Sep 3, 2024
| idxColumnsSets :: [S.Set Text] | ||
| idxColumnsSets = cname . idxColumns <$> indexes | ||
| -- Map index on the given table name to a list of list of names | ||
| -- So that index on a and index on (b, c) becomes [[a], [b, c,]] |
There was a problem hiding this comment.
Suggested change
| -- So that index on a and index on (b, c) becomes [[a], [b, c,]] | |
| -- so that index on a and index on (b, c) becomes [[a], [b, c]]. |
| allCoverage = maybe [] pkColumns pkey:allIndexes | ||
|
|
||
| -- A foreign key is covered if it is a prefix of a list of indices. | ||
| -- So a FK on a is covered by an index on (a, b) but not an index on (b, a) |
There was a problem hiding this comment.
Suggested change
| -- So a FK on a is covered by an index on (a, b) but not an index on (b, a) | |
| -- So a FK on a is covered by an index on (a, b) but not an index on (b, a). |
Raveline
force-pushed
the
fix-index-detection
branch
from
d247b4e
to
36f76e1
Compare
|
Sorry about punctuation, I'll try to remember this for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two limitations of our current index-on-fk checker: